Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Unlock): add container for max width on options screen #2263

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

lujakob
Copy link
Contributor

@lujakob lujakob commented Mar 24, 2023

Describe the changes you have made in this PR

Fixes #2262

Add screenshots to make your changes easier to understand. You can also add a video here.

Bildschirmfoto 2023-03-24 um 14 52 24

Bildschirmfoto 2023-03-24 um 14 51 57

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Tested manually

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@github-actions
Copy link

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@reneaaron
Copy link
Contributor

@lujakob Thanks for the PR 🙌

The change makes sense, however I wondered how (as a user) you would see the unlock page in the website (and not in the popup)? 🤔

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@lujakob
Copy link
Contributor Author

lujakob commented Mar 25, 2023

@lujakob Thanks for the PR 🙌

The change makes sense, however I wondered how (as a user) you would see the unlock page in the website (and not in the popup)? 🤔

I see it all the time. So basically it's just for my own sanity 😉

When I'm not logged in, open the app from the Chrome "Extensions" popup and click on "Options".

Bildschirmfoto 2023-03-25 um 07 21 16

@reneaaron reneaaron merged commit ded7358 into getAlby:master Mar 25, 2023
@reneaaron
Copy link
Contributor

I see, never used it that way. Thanks for the explanation and your initiative here 🙌

SiddheshKukade added a commit to SiddheshKukade/lightning-browser-extension that referenced this pull request Mar 26, 2023
reneaaron pushed a commit that referenced this pull request Apr 3, 2023
…a new category: Node management (#2233)

* refactor: changed order of sections on discover page

* feat: add node management section on discover

* refactor: added new options to node management from misc

* refactor: replaced link with CDN link

* feat(docs): add docs for choose_path and �lby

* feat(docs): add docs for choose_connector

* feat(docs): add hindi translation for permissions

* feat(docs): add hindi translation

* Revert "feat(Unlock): add container for max width on options screen (#2263)"

This reverts commit ded7358.

* fix: removed extra changes from translation file

* fix: removed extra spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] options page unlock screen max width
2 participants