-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onboarding add pin extension screen #2347
feat: onboarding add pin extension screen #2347
Conversation
I added code to detect dark mode browser setting, taken from
I changed my Chrome browser setting to dark mode. The welcome screen appears dark, but the mechanism to detect it as taken from Anyways, if the code in |
🚀 Thanks for the pull request! Here are the current build files for testing: Download and unzip the file for your browser. Refer to the readme for detailed install instructions. This build is brought to you by: Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name) Don't forget: keep earning sats! |
@lujakob You are on 🔥, great job! Just tested it and worked fine for me. 💪 Some minor things I noticed during testing:
Will continue with the code review probably later today / tomorrow, but looks quite good! |
667655c
to
0cc59c4
Compare
|
0cc59c4
to
9d7c911
Compare
@reneaaron Thanks for reviewing. I resolved all issues. |
01a0b4f
to
53a2103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 little nitpicks, other than that: 💯
Thanks also for taking the time to rename some functions and introducing a new useTheme
hook. 💪
tACK
Sounds good. I updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested another time, added some fixes regarding spacing. Great job! 💪
tACK
Thanks for reviewing 🙏 |
I removed the onboarding card now too, since those are kind of duplicate otherwise. cc @stackingsaunter |
Describe the changes you have made in this PR
Add a pin extension screen as last step of onboarding.
Link this PR to an issue
Fixes #2343
Type of change
feat
: New feature (non-breaking change which adds functionality)Screenshots of the changes [optional]
How has this been tested?
Manually
Checklist