Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Music Side Project and CurioCaster to the "Discover" page #2354

Merged
merged 5 commits into from
May 2, 2023

Conversation

AdarshRawat1
Copy link
Contributor

@AdarshRawat1 AdarshRawat1 commented Apr 16, 2023

Describe the changes you have made in this PR

Added https://musicsideproject.com/ and https://curiocaster.com/ to the "Discover" page under entertainment section.

Link this PR to an issue [optional]

Fixes _ #2353 by @MoritzKa

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Screenshots of the changes [optional]

Current Discover Page -
image

Updated Discover Page-
image

Note

I have not yet uploaded the logos to the Content Delivery Network (CDN). Currently, I am using GitHub links. Could you please assist me with uploading them to the CDN as I am not familiar with the process?

Checklist

  • My code follows the style guidelines of this project and performed a self-review of my own code
  • New and existing tests pass locally with my changes
  • I checked if I need to make corresponding changes to the documentation (and made those changes if needed)

@AdarshRawat1 AdarshRawat1 changed the title Added Music Side Project and CurioCaster to the "Discover" pages Added Music Side Project and CurioCaster to the "Discover" page Apr 16, 2023
@github-actions
Copy link

github-actions bot commented Apr 16, 2023

🚀 Thanks for the pull request!

Here are the current build files for testing:

Download and unzip the file for your browser. Refer to the readme for detailed install instructions.


This build is brought to you by: channel.ninja (who recently dropped 1000 sats):


Want to sponsor the next build? send some sats to ⚡️builds@getalby.com (don't forget to provide your name)

Don't forget: keep earning sats!

@AdarshRawat1
Copy link
Contributor Author

@MoritzKa I have updated the links. Please review the changes.
Do you think the resolution of the Music Side Project logo needs to be adjusted?
Screenshot -
image

@MoritzKa
Copy link
Contributor

@jankoegel do you know why the thumbnail is cut off?
It appears a bit blurry here on GitHub.
compared to the original file:
musicsideproject_thumbnail

@reneaaron
Copy link
Contributor

now why the thumbnail is cut off?
It appears a bit blurry here on GitHub.

It's because the images are supposed to be squares. (it's 330x300)

@jankoegel
Copy link
Contributor

@jankoegel do you know why the thumbnail is cut off? It appears a bit blurry here on GitHub. compared to the original file:

here's the image converted to a square (333x333px) and compressed:
musicsideproject_thumbnail_2

@AdarshRawat1
Copy link
Contributor Author

AdarshRawat1 commented Apr 17, 2023

Thank you @reneaaron, @jankoegel and @MoritzKa for your guidance. @jankoegel, the converted image looks good. Could you please upload this logo to the CDN? Thank you.

Screenshot of Converted Logo (333x333px) compressed -
image

Zoomed in -
image

@MoritzKa
Copy link
Contributor

Thanks a lot, guys!!!

@AdarshRawat1
Copy link
Contributor Author

@jankoegel do you know why the thumbnail is cut off? It appears a bit blurry here on GitHub. compared to the original file:

here's the image converted to a square (333x333px) and compressed: musicsideproject_thumbnail_2

@MoritzKa Kindly add this logo to CDN and provide the link.

@AdarshRawat1
Copy link
Contributor Author

AdarshRawat1 commented Apr 19, 2023

@reneaaron
Copy link
Contributor

tACK

@bumi bumi merged commit 44f9f69 into getAlby:master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants