feat: disable autocomplete on other form fields #2595
Conversation
don't allow password manager to fill password field other then fields on unlock screen add types to text fields signed-off-by: pavan joshi <pavanj914@gmail.com>
src/app/screens/Send/index.tsx
Outdated
| @@ -126,6 +126,7 @@ function Send() { | |||
| <div className="pt-4"> | |||
| <TextField | |||
| id="invoice" | |||
| type="text" | |||
There was a problem hiding this comment.
Why did you add the type everywhere? It's "text" by default?
There was a problem hiding this comment.
we have type added as text at few of the text field and few of them doesn't contain them. so shall we remove type field at all the fields containing type="text"
it's better to be consistent!
There was a problem hiding this comment.
having type explicitly in the code would be better and readable isn't it?
reneaaron
changed the title
src/app/screens/LNURLPay/index.tsx
Outdated
| @@ -497,6 +498,7 @@ function LNURLPay() { | |||
| <div className="mt-4"> | |||
| <TextField | |||
| id="name" | |||
| type="text" | |||
There was a problem hiding this comment.
I think type text is default
There was a problem hiding this comment.
we have type="text" at few of the text field and few of them doesn't contain them. it's better to be consistent!
shall we remove it from everywhere or add it everywhere? isn't this better and readable to have type explicitly defined
| @@ -175,6 +176,7 @@ export default function ConnectLnd() { | |||
| <div> | |||
| <TextField | |||
| id="macaroon" | |||
| type="text" | |||
There was a problem hiding this comment.
let's make this also a password field
| @@ -133,6 +133,7 @@ export default function ConnectMyNode() { | |||
| <div className="mt-6"> | |||
| <TextField | |||
| id="lndconnect" | |||
| type="text" | |||
There was a problem hiding this comment.
let's make this also a password field
| @@ -164,6 +165,7 @@ export default function ConnectRaspiBlitz() { | |||
| <div> | |||
| <TextField | |||
| id="macaroon" | |||
| type="text" | |||
There was a problem hiding this comment.
let's make this also a password field
| @@ -136,6 +136,7 @@ export default function ConnectStart9() { | |||
| <div className="mt-6"> | |||
| <TextField | |||
| id="lndconnect" | |||
| type="text" | |||
There was a problem hiding this comment.
let's make this also a password field.
lndconnect holds secrets and thus we can handle it as a password field I guess.
| @@ -133,6 +133,7 @@ export default function ConnectUmbrel() { | |||
| <div className="mt-6"> | |||
| <TextField | |||
| id="lndconnect" | |||
| type="text" | |||
There was a problem hiding this comment.
let's make this also a password field
Describe the changes you have made in this PR
don't allow password manager to fill password field other then fields on unlock screen add types to text fields
Link this PR to an issue [optional]
Fixes #2489 new pr for #2497
Type of change
fix: Bug fix (non-breaking change which fixes an issue)How has this been tested?
manually checking auto complete on firefox
Checklist