-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement allowances and sites pages UX/UI improvements #2617
Conversation
52b8d45
to
24291d2
Compare
fix: getAlby#2458 Co-Authored-By: Fabricio C Zuardi <fabricio@fabricio.org> Co-Authored-By: M. Quasar <marcosm@gmail.com> Co-Authored-By: GabrielSoga <19688935+GabrielSoga@users.noreply.github.com>
24291d2
to
04d95b6
Compare
Thanks for the PR! I can't test it without a build though |
@fczuardi @GabrielSoga Thanks for this PR! 👍 Could you please have a look at the unit tests? Some of them seem to fail currently. Planning to test / review this PR later today / start of next week. |
@GabrielSoga Great job with this PR! 👍 From a functional perspective everything seemed to work as expected, I've pushed some minor improvements / fixes to this branch here: https://github.com/getAlby/lightning-browser-extension/tree/budgets-new-ux Will continue with the code review next week. Have a nice weekend! 😎 |
Unit tests are updated. |
Builds are good now @stackingsaunter :) |
Tested, looks really nice, great job @GabrielSoga !!! Thanks you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tAck
@reneaaron can we do something to help this branch? what are the next steps? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much again for this PR, great work guys! 💯
I've added some minor fixes (responsive layout, color usage, created a Modal component to avoid code reuse, etc) and left a few comments.
Apart from the "division by zero" this looks good to merge from my side.
I've now also fixed those things.
tACK
nice cleanup! we like it :) |
Describe the changes you have made in this PR
Budgets UX/UI improvements:
Link this PR to an issue
#2458
Type of change
(Remove other not matching type)
feat
: New feature (non-breaking change which adds functionality)How has this been tested?
Manual testing
Checklist