fix: make wallet page the startpage for the options view #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm. I am not sure about that. |
|
I think the wallet just makes more sense here: from there users can access the most commonly used actions (send, receive, etc). I can't imagine a situation where it would be more helpful to be taken to the websites than the wallet page when I switch accounts. (it's also the same behavior as in the popup) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
On the options.html page
/currently redirects you to the websites.Since we redirect users to
/when switching accounts this takes you to the websites page.I think it would be better to take users to the wallet page as it's probably the most commonly used one.