Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fast provider injection 🔥 #2691

Merged
merged 40 commits into from
Aug 28, 2023
Merged

feat: fast provider injection 🔥 #2691

merged 40 commits into from
Aug 28, 2023

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

Improvements for #2672

pavanjoshi914 and others added 29 commits August 16, 2023 13:54
@pavanjoshi914
feat: add webln
c6aa828
@reneaaron
fix: all_frames property name
b4284f4
@pavanjoshi914
feat: use service worker instead of manifest
ba3b28a
@pavanjoshi914
feat: inject content scripts on start
6f18328
@pavanjoshi914
feat: inline and inject provider in mv2 via custom webpack plugin
2a928b9 
intercept build files add provider during build time and inject
signed-off-by: pavan joshi <pavanj914@gmail.com>
@pavanjoshi914
chore: comment/refactor
3818f37
@reneaaron
fix: use helper function
1a222ca
@reneaaron
fix: move injection from onend to onstart
f27d985
@reneaaron
fix: remove injectScripts, separate WebLN from index
a6b23a3
@reneaaron
fix: add inpage script registration for other providers
a35bfc7
@reneaaron
fix: added todo
08eae51
@reneaaron
fix: remove web accessible resources
1ab6ea2
@reneaaron
fix: separate index from webln
5fa846e
@reneaaron
fix: rename scripts, merge manifest content script definition
60db42e
@pavanjoshi914
feat: rewrite webpack plugin
0d559c9 
inject all the provider via single variable
solve plugin error, while inlinining all the scripts in single variable
signed-off-by: pavan joshi <pavanj914@gmail.com>
@pavanjoshi914
feat: add webln
d0a73e0
@reneaaron @pavanjoshi914
fix: all_frames property name
ea03cd7
@pavanjoshi914
feat: use service worker instead of manifest
403f528
@pavanjoshi914
feat: inject content scripts on start
a1a79ea
@pavanjoshi914
feat: inline and inject provider in mv2 via custom webpack plugin
5f51c2f 
intercept build files add provider during build time and inject
signed-off-by: pavan joshi <pavanj914@gmail.com>
@pavanjoshi914
chore: comment/refactor
b9fc28e
@reneaaron @pavanjoshi914
fix: use helper function
4804fda
@reneaaron @pavanjoshi914
fix: move injection from onend to onstart
eb28ad8
@reneaaron @pavanjoshi914
fix: remove injectScripts, separate WebLN from index
e19f81e
@reneaaron @pavanjoshi914
fix: add inpage script registration for other providers
e72c169
@reneaaron @pavanjoshi914
fix: added todo
cd6cf2e
@reneaaron @pavanjoshi914
fix: remove web accessible resources
9b1b61b
@reneaaron @pavanjoshi914
fix: separate index from webln
3f07b7a
@reneaaron @pavanjoshi914
fix: rename scripts, merge manifest content script definition
babc541
@reneaaron reneaaron changed the base branch from master to inject-webln-in-world August 23, 2023 18:41
@reneaaron reneaaron changed the base branch from inject-webln-in-world to master August 23, 2023 18:41
@pavanjoshi914
feat: do brower side checks in the inpage script itself
5c282a5 
do browser side checks + extension side cheks such as blocklist in the provider's content script
signed-off-by: pavan joshi <pavanj914@gmail.com>
@pavanjoshi914 pavanjoshi914 marked this pull request as ready for review August 24, 2023 06:40
@pavanjoshi914 pavanjoshi914 requested a review from bumi August 24, 2023 06:41
@pavanjoshi914
Copy link
Contributor

pavanjoshi914 commented Aug 24, 2023 •
edited
Loading

  1. new changes include, doing browser side checks in the inpagescript itself so that those checks work for mv3 and mv2 both

  2. handle browser side check + extension side check such as blocklist in the providers content script itself. so that it works both on mv2 and mv3

like this we achieve common behaviour on both mv2 and mv3

  1. script is injected from onStart.ts and background script
  2. in page script itself checks document type, suffix, and script element if everything is fine script is injected. if not script will not injected
  3. If inpage is injected, if user performs some call. shouldInject from content script is responsible for handling blocklist via should inject present in there, hence blocklist will work on both mv2 and mv3 as well

cc @reneaaron @bumi

@reneaaron reneaaron changed the title WIP: provider injection feat: fast provider injection 🔥 Aug 24, 2023
reneaaron
reneaaron commented Aug 24, 2023
View reviewed changes
Copy link
Contributor Author

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both in firefox and chrome. 💯

tACK

@reneaaron reneaaron requested a review from bumi August 24, 2023 13:11
This was referenced Aug 24, 2023
Closed
Closed
@reneaaron reneaaron mentioned this pull request Aug 25, 2023
Closed
@bumi bumi merged commit f98edca into master Aug 28, 2023
@bumi bumi deleted the feat/window-provider branch August 28, 2023 10:27
@alexgleason alexgleason mentioned this pull request Jul 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavanjoshi914 pavanjoshi914 pavanjoshi914 left review comments

@bumi bumi Awaiting requested review from bumi

Assignees
No one assigned
Labels
None yet
Projects
🐝 Alby
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@reneaaron @pavanjoshi914 @bumi