-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable the checkbox for budget control during payments #2731
Conversation
@reneaaron I have made the changes for disabling the checkbox and to indicate that it is disabled I have blurred the label and the checkbox. |
You should disable it during the payment process, also I'd prefer reduced opacity to blur, thoughts @reneaaron? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the PR! 🖐️
I've left some first feedback. 👌
@reneaaron @rolznz made the requested changes. |
@rolznz done the mentioned change, can u review it now. |
@Rithvik-padma can you also disable the budget control for keysend payments? |
Unfortunately I cannot update this branch. I believe it's because you did not create a branch for this PR, but made a PR from master. |
Sure will do that! |
Yes I am using the master branch for it. |
@rolznz I have disabled the budget control for the keysend payments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
I don't believe any styling changes are necessary.
Thanks for your work, @Rithvik-padma ! |
Describe the changes you have made in this PR
Fixes - #2638
Type of change
fix
: Bug fix (non-breaking change which fixes an issue)Post changes
chrome_nE4WXh1aEy.mp4
How has this been tested?
Ran all the tests.
Checklist