Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shift the buttons to the bottom in LNURLpay screen view #2742

Merged
merged 7 commits into from
Sep 14, 2023

Conversation

Rithvik-padma
Copy link
Contributor

Describe the changes you have made in this PR

Shifted the confirm and cancel buttons in the LNURL screen view to the bottom

Link this PR to an issue

Fixes #2663

Type of change

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes

Before the changes

image

After the changes

image

How has this been tested?

Tested the screens manually by trying to pay on some sites in LNURL mode.

Checklist

  • Self-review of changed code
  • Manual testing
  • Responsive layout

@Rithvik-padma
Copy link
Contributor Author

@stackingsaunter @rolznz Can u review this PR.
Thanks

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, just did a first review! 💯

src/app/screens/LNURLPay/index.tsx Outdated Show resolved Hide resolved
@Rithvik-padma
Copy link
Contributor Author

Rithvik-padma commented Sep 8, 2023

@reneaaron @rolznz Made the changes, can u review it
Thanks!

Copy link
Contributor

@rolznz rolznz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Rithvik-padma
Copy link
Contributor Author

tACK

@reneaaron Can u review these changes too.
Thanks!

@rolznz rolznz merged commit 6fbb7f7 into getAlby:master Sep 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Confirm and cancel buttons should be on bottom
3 participants