Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add de to supported locales #2854

Merged
merged 5 commits into from
Nov 9, 2023
Merged

feat: add de to supported locales #2854

merged 5 commits into from
Nov 9, 2023

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Nov 8, 2023

Describe the changes you have made in this PR

This PR enables "German" as a language in the extension. Translations seem more or less complete, however there are quite some really bad translations in there (e.g. connected sites <> Verbundene Standorte) 😓

Would love to get some help from a native german speaking person on reviewing the translations on Weblate and making sure everything is properly translated:

https://hosted.weblate.org/projects/getalby-lightning-browser-extension/getalby-lightning-browser-extension/de/

@reneaaron reneaaron marked this pull request as ready for review November 9, 2023 21:57
@reneaaron reneaaron enabled auto-merge (squash) November 9, 2023 21:57
@reneaaron reneaaron merged commit c7abdbb into master Nov 9, 2023
6 of 7 checks passed
@reneaaron reneaaron deleted the feat/german branch November 9, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant