Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: caching getInfo calls #2864

Merged
merged 3 commits into from
Nov 15, 2023
Merged

fix: caching getInfo calls #2864

merged 3 commits into from
Nov 15, 2023

Conversation

reneaaron
Copy link
Contributor

@reneaaron reneaaron commented Nov 14, 2023

Describe the changes you have made in this PR

Cache getInfo() calls on connector level for the lifetime of the connector. (changing accounts will reload the info as every time a new instance is created)

@bumi
Copy link
Collaborator

bumi commented Nov 15, 2023

can we get this in?

@reneaaron reneaaron marked this pull request as ready for review November 15, 2023 22:04
@reneaaron
Copy link
Contributor Author

tACK

cc @rolznz

@reneaaron reneaaron enabled auto-merge (squash) November 15, 2023 22:06
@reneaaron reneaaron changed the title WIP: fix: caching getInfo calls fix: caching getInfo calls Nov 15, 2023
@reneaaron reneaaron enabled auto-merge (squash) November 15, 2023 22:06
@reneaaron reneaaron merged commit e5eb4ef into master Nov 15, 2023
6 of 7 checks passed
@reneaaron reneaaron deleted the fix/cache-getinfo branch November 15, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants