Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add description to transaction modal, layout fixes #2867

Merged
merged 2 commits into from
Nov 19, 2023

Conversation

reneaaron
Copy link
Contributor

Describe the changes you have made in this PR

image

  • Adds the title to the detail layout
  • Some smaller layout fixes for overflowing text

@reneaaron reneaaron force-pushed the fix/transaction-details-description branch from d471332 to afc5af0 Compare November 14, 2023 22:36
{children}
</dt>
);

const Dd = ({ children }: { children: React.ReactNode }) => (
<dd className="flex-1 text-gray-800 dark:text-neutral-200 break-all whitespace-pre-wrap">
<dd className="text-gray-800 dark:text-neutral-200 break-words whitespace-pre-wrap overflow-hidden">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break-words + overflow-hidden breaks long text "aaaaaaaaa...aaaaa" inside of words, but doesn't just break words in-between.

@reneaaron reneaaron requested review from rolznz and pavanjoshi914 and removed request for rolznz November 15, 2023 22:14
Copy link
Contributor

@pavanjoshi914 pavanjoshi914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@pavanjoshi914 pavanjoshi914 merged commit 4c5e739 into master Nov 19, 2023
6 of 7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the fix/transaction-details-description branch November 19, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants