fix: don't allow to bypass unlock screen and access welcome screen #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… welcome component security fix to not allow to bypass unlock screen and read unsensitive data
bumi
reviewed
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
security fix to not allow to bypass unlock screen and read unsensitive data
Link this PR to an issue [optional]
Fixes #2915
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)How has this been tested?
try to access welcome.html when the extension is unlocked and locked.
Checklist