feat: max popup screens fit #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavanjoshi914
changed the title
|
@pavanjoshi914 Tested and noticed that for popups exceeding the height of the popup (e.g. nostr signing with expanded details) the buttons have no margin to the bottom anymore:
I was wondering if we really should introduce a |
|
@reneaaron thats a prompt right? sry i didn't make changes in prompt view(only in popup view). latest commit will fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
fix normal popups and popups which has additonal expandible fields such as lnurlpay popup
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)Checklist