Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: responsive account settings + settings page #2958

Merged
merged 8 commits into from
Feb 29, 2024
Merged

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

make settings page responsive

Link this PR to an issue [optional]

Type of change

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@pavanjoshi914 pavanjoshi914 changed the title feat: responsive tip cards feat: responsive settings page Dec 22, 2023
@pavanjoshi914 pavanjoshi914 changed the title feat: responsive settings page feat: responsive account settings page Dec 27, 2023
@reneaaron
Copy link
Contributor

Before:
image

After:
image

IMO this is worse than it was before, as there is no visual rhythm, missing spacing between elements, inconsistent alignment of text, etc.

@pavanjoshi914
Copy link
Contributor Author

image
this pr was for the account settings page and not the settings page. as we use refactored component it breaked settings page checking it

@pavanjoshi914 pavanjoshi914 changed the title feat: responsive account settings page feat: responsive account settings + settings page Jan 30, 2024
add new property to keep few settings inline optionally such as toggle
@pavanjoshi914
Copy link
Contributor Author

@reneaaron i corrected settings page in the same pr

@pavanjoshi914
Copy link
Contributor Author

image

  • added new property to keep few settings inline on smaller screens such as toggles

@reneaaron reneaaron added the next-release To be included in the next release label Feb 8, 2024
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron reneaaron merged commit 097c181 into master Feb 29, 2024
6 checks passed
@reneaaron reneaaron deleted the feat/settings-page branch February 29, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants