Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new ui home screen and receive screen #2983

Merged
merged 16 commits into from
Feb 22, 2024
Merged

Conversation

pavanjoshi914
Copy link
Contributor

Describe the changes you have made in this PR

new ui for home screen and receive screen

Link this PR to an issue [optional]

Fixes #2922

Type of change

(Remove other not matching type)

  • feat: New feature (non-breaking change which adds functionality)

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

Copy link
Contributor

@stackingsaunter stackingsaunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, tested PR with existing account, a few minor fixed are needed:

  • delete shadow from card-buttons
  • add 1px border to card-buttons
  • bitcoin icon on "Bitcoin address" card needs to be swapped for those from Popicons
  • could you add 2px spacing between title and paragraph in the card?

@pavanjoshi914
Copy link
Contributor Author

@stackingsaunter using border instead of shadow there leading to card taking more space and cutting text into new line

image

@pavanjoshi914
Copy link
Contributor Author

pavanjoshi914 commented Jan 23, 2024

maybe we can use 12px item spacing instead of 16 px

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently the two cards for the mnemonic are always being displayed:

image

Also after backing up or importing it, which IMO is not shipable in it's current form.

What about we introduce a backupDone property that is being set when confirming the backups / importing an external mnemonic?

@pavanjoshi914
Copy link
Contributor Author

added. functionality to add new property isMnemonicBackupDone and use it to show card when it's relevent to show

@pavanjoshi914
Copy link
Contributor Author

for backup screen i will just set the property to true when new ui for mnemonic onboarding is merged. currently it is set only in generateScreen

@pavanjoshi914
Copy link
Contributor Author

pavanjoshi914 commented Jan 29, 2024

@stackingsaunter using border instead of shadow there leading to card taking more space and cutting text into new line

image

i reduced item-sacing from 16 to 12 px to resolve above

@reneaaron reneaaron added the next-release To be included in the next release label Feb 8, 2024
Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@reneaaron
Copy link
Contributor

@pavanjoshi914 Please fix the tests.

Copy link
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK (some more changes will need to be done in a followup PR)

@reneaaron reneaaron merged commit dc37cc0 into master Feb 22, 2024
7 of 8 checks passed
@reneaaron reneaaron deleted the feat/new-popup-buttons branch February 22, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New onboarding/notifications popup item buttons
3 participants