-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new ui home screen and receive screen #2983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, tested PR with existing account, a few minor fixed are needed:
- delete shadow from card-buttons
- add 1px border to card-buttons
- bitcoin icon on "Bitcoin address" card needs to be swapped for those from Popicons
- could you add 2px spacing between title and paragraph in the card?
@stackingsaunter using border instead of shadow there leading to card taking more space and cutting text into new line |
maybe we can use 12px item spacing instead of 16 px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added. functionality to add new property isMnemonicBackupDone and use it to show card when it's relevent to show |
for backup screen i will just set the property to true when new ui for mnemonic onboarding is merged. currently it is set only in generateScreen |
i reduced item-sacing from 16 to 12 px to resolve above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
@pavanjoshi914 Please fix the tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK (some more changes will need to be done in a followup PR)
Describe the changes you have made in this PR
new ui for home screen and receive screen
Link this PR to an issue [optional]
Fixes #2922
Type of change
(Remove other not matching type)
feat
: New feature (non-breaking change which adds functionality)Checklist