feat: update react-i18next config #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/i18next-browser-languagedetector@7.1.0, npm/i18next@22.5.1, npm/react-i18next@12.3.1 |
pavanjoshi914
changed the title
pavanjoshi914
commented
Feb 1, 2024
| @@ -92,6 +92,7 @@ export default function PasswordForm< | |||
| <TextField | |||
| autoFocus={autoFocus} | |||
| id="password" | |||
| // @ts-ignore/currently ignore | |||
There was a problem hiding this comment.
@reneaaron i was able to correct other breaking changes but this one, not yet. it always throw type safe errors. any idea why this happening?
There was a problem hiding this comment.
There was a problem hiding this comment.
Can't explain it either, must be caused by the keyPrefix being passed to the component. 🤷♂️
reneaaron
approved these changes
Feb 8, 2024
| @@ -92,6 +92,7 @@ export default function PasswordForm< | |||
| <TextField | |||
| autoFocus={autoFocus} | |||
| id="password" | |||
| // @ts-ignore/currently ignore | |||
There was a problem hiding this comment.
Can't explain it either, must be caused by the keyPrefix being passed to the component. 🤷♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
A clear and concise description of what you want to happen
Link this PR to an issue [optional]
Fixes #ISSUE-NUMBER
Type of change
(Remove other not matching type)
fix: Bug fix (non-breaking change which fixes an issue)feat: New feature (non-breaking change which adds functionality)feat!: Breaking change (fix or feature that would cause existing functionality to not work as expected)docs: Documentation updateScreenshots of the changes [optional]
Add screenshots to make your changes easier to understand. You can also add a video here.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist