Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mnemonic): restrict input fields to 12 #3039

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

im-adithya
Copy link
Member

Describe the changes you have made in this PR

Pops the words after 12, so that we can restrict the mnemonic inputs to 12 max.

Link this PR to an issue [optional]

Fixes #3038

Type of change

(Remove other not matching type)

  • fix: Bug fix (non-breaking change which fixes an issue)

Screenshots of the changes [optional]

Screen.Recording.2024-02-13.at.11.40.56.AM.mov

How has this been tested?

Tested Manually

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable (Not Applicable)
  • Update Docs & Guides (Not Applicable)
  • For UI-related changes
  • Darkmode (Not Applicable)
  • Responsive layout (Not Applicable)

Copy link
Contributor

@pavanjoshi914 pavanjoshi914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix tAck

@pavanjoshi914 pavanjoshi914 merged commit 8988604 into master Feb 13, 2024
6 of 7 checks passed
@pavanjoshi914 pavanjoshi914 deleted the task-fix-mnemonic branch February 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Mnemonic grows to more than 12 fields
2 participants