feat: update extension settings layout #3069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
amitamrutiya
changed the title
reneaaron
reviewed
Mar 8, 2024
src/i18n/locales/en/translation.json
Outdated
| @@ -594,12 +593,16 @@ | |||
| }, | |||
| "settings": { | |||
| "title": "Extension Settings", | |||
| "subtitle": "Global settings that affect your experience on all connected wallet in Alby Extension.", | |||
There was a problem hiding this comment.
Suggested change
| "subtitle": "Global settings that affect your experience on all connected wallet in Alby Extension.", | |
| "subtitle": "Global settings that affect your experience on all connected wallets in Alby Extension.", |
reneaaron
requested changes
Mar 8, 2024
Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
Signed-off-by: amitamrutiya2210 <amitamrutiya2210@gmail.com>
reneaaron
added
the
after-next-release
|
Hey @amitamrutiya2210 are you still working on this one? |
|
From my side, the work is done. So, this PR is ready for review. |
|
@amitamrutiya2210 I see thanks 🙏🙏 |
reneaaron
added
next-release
pavanjoshi914
changed the title
|
Thanks for the pr! fixed some layout issues and styles and code conventions. @reneaaron let me know if want some additional changes! TODO: update wallet settings this focus only on extension settings |
|
Rest LGTM! |
|
regarding outdated translations warnings. i don't think we shall remove it. it's just that strings were capitalised in English version |
|
tAck |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made in this PR
I have implemented the recommended changes mentioned in the issue. In this PR I make sure that:
Link this PR to an issue [optional]
#2874
Fixes #2874
Type of change
Screenshots of the changes [optional]
Checklist