fix: correct total amount in notifcations #3194
Conversation
| @@ -22,7 +22,7 @@ const paymentSuccessNotification = async ( | |||
|
|
|||
| const route = paymentResponseData?.data.route; | |||
| const { total_amt, total_fees } = route; | |||
| const paymentAmount = total_amt - total_fees; | |||
| const paymentAmount = total_amt; | |||
There was a problem hiding this comment.
I am not sure if this is correct for all the connectors?
is that correct for LND, NWC, alby?
There was a problem hiding this comment.
alby to lndhub -correct
lndhub to alby - fees is always zero. total amount is correct no issues
lnd to lnd (testnet) - correct
nwc to alby oauth - totalAmount correct, fees shown 0
alby oauth to nwc - totalAmount correct, fees shown 8 sats
There was a problem hiding this comment.
for all the cases totalAmount is correct which is the amount that user paid. but in some cases even if fees is charged fees is not returned in the route which maybe corrected on server side
There was a problem hiding this comment.
So I think LND returns the total_amt with the fees (which is why we deduct it here)
but all others return the paid amount without the fee.
which means your change is OK. but we might need to change the LND connector to return the sent amount.
pavanjoshi914
changed the title
show totalamount including fees in the notifcations as we do in the transactions table Fixes #3192