Merge pull request #88 from getAlby/fix/list-transactions-limit

fix: ldk list transactions limit

handle_list_transactions_request.go

@@ -44,9 +44,10 @@ func (svc *Service) HandleListTransactionsEvent(ctx context.Context, request *Ni
 	}).Info("Fetching transactions")
 
 	limit := listParams.Limit
-	if limit == 0 {
+	maxLimit := uint64(50)
+	if limit == 0 || limit > maxLimit {
 		// make sure a sensible limit is passed
-		limit = 50
+		limit = maxLimit
 	}
 	transactions, err := svc.lnClient.ListTransactions(ctx, listParams.From, listParams.Until, limit, listParams.Offset, listParams.Unpaid, listParams.Type)
 	if err != nil {

ldk.go

@@ -7,6 +7,7 @@ import (
 	"log"
 	"os"
 	"path/filepath"
+	"sort"
 	"strconv"
 	"sync"
 	"time"
@@ -317,6 +318,7 @@ func (gs *LDKService) LookupInvoice(ctx context.Context, paymentHash string) (tr
 func (gs *LDKService) ListTransactions(ctx context.Context, from, until, limit, offset uint64, unpaid bool, invoiceType string) (transactions []Nip47Transaction, err error) {
 	transactions = []Nip47Transaction{}
 
+	// TODO: support pagination
 	payments := gs.node.ListPayments()
 
 	for _, payment := range payments {
@@ -326,9 +328,12 @@ func (gs *LDKService) ListTransactions(ctx context.Context, from, until, limit,
 	}
 
 	// sort by created date descending
-	/*sort.SliceStable(transactions, func(i, j int) bool {
+	sort.SliceStable(transactions, func(i, j int) bool {
 		return transactions[i].CreatedAt > transactions[j].CreatedAt
-	})*/
+	})
+
+	// locally limit for now
+	transactions = transactions[:limit]
 
 	return transactions, nil
 }