Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Implement RedeemOnchainFunds() for LDK and Greenlight #131

Merged
merged 6 commits into from
Mar 20, 2024

Conversation

rdmitr
Copy link
Collaborator

@rdmitr rdmitr commented Mar 18, 2024

No description provided.

@rdmitr rdmitr force-pushed the feat/ldk-gl-redeem-onchain-funds branch from 98efb7d to 2046146 Compare March 18, 2024 21:32
@rdmitr rdmitr requested a review from rolznz March 18, 2024 21:33
@rolznz
Copy link
Collaborator

rolznz commented Mar 19, 2024

Dependent upon getAlby/hub#172

@rolznz
Copy link
Collaborator

rolznz commented Mar 19, 2024

For Greenlight regarding failure to withdraw funds:

I got this reply:

Hi Roland, thanks for reporting. We are currently dealing with a bunch of things that werent quite ready to handle the scale up last week. One of them was adding a load balancer, which has a shorter keepalive interval, and drops connections that were inactive for several seconds. We have a patch for the client library, but need to address a slow notification first which would otherwise worsen. So the command was delivered but the connection was dropped due to a slow response.

I guess we need to wait for them to apply the fix, and then update glalby to use the latest greenlight version.

@rolznz
Copy link
Collaborator

rolznz commented Mar 19, 2024

LDK works well!

@rolznz rolznz changed the base branch from feat/breez-redeem-onchain-funds to master March 19, 2024 15:24
@rolznz
Copy link
Collaborator

rolznz commented Mar 19, 2024

I wonder if we should just merge this PR and update glalby bindings once the greenlight issue is fixed.

@rolznz
Copy link
Collaborator

rolznz commented Mar 19, 2024

@rdmitr does that sound ok to you?

@rolznz
Copy link
Collaborator

rolznz commented Mar 19, 2024

@rdmitr we need to update the glalby bindings to support mac first though - could you update them here getAlby/glalby-go#5 and then consume the new commit hash?

@rdmitr
Copy link
Collaborator Author

rdmitr commented Mar 19, 2024

@rolznz the bindings have been updated and merged 👍

@rolznz rolznz merged commit 16f713f into master Mar 20, 2024
2 checks passed
@rdmitr rdmitr deleted the feat/ldk-gl-redeem-onchain-funds branch March 20, 2024 20:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redeem onchain funds (LDK/Greenlight)
2 participants