Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

feat: node selection #387

Merged
merged 14 commits into from
Jun 10, 2024
Merged

feat: node selection #387

merged 14 commits into from
Jun 10, 2024

Conversation

reneaaron
Copy link

@reneaaron reneaaron commented Jun 5, 2024 •
edited
Loading

TODO

  • Icons (currently only work for light mode well)
  • LDK configuration screen (empty, skip it?)

@reneaaron reneaaron mentioned this pull request Jun 5, 2024
Closed
2 tasks
@reneaaron reneaaron marked this pull request as ready for review June 6, 2024 12:05
@reneaaron reneaaron requested a review from rolznz June 6, 2024 12:05
rolznz
rolznz reviewed Jun 7, 2024
View reviewed changes
frontend/src/screens/setup/node/LNDForm.tsx
setupStore.nodeInfo.lndMacaroonHex || ""
);

// TODO: proper onboarding
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this TODO still needed?

@rolznz
Copy link
Collaborator

rolznz commented Jun 7, 2024

@reneaaron really nice changes! I'll try help fix this issue with existing env variables set for LND (will be the case for Umbrel/Start9)

@rolznz rolznz mentioned this pull request Jun 8, 2024
Merged
@rolznz rolznz merged commit 9b33061 into master Jun 10, 2024
6 checks passed
@rolznz rolznz deleted the feat/node-selection-v2 branch June 10, 2024 07:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rolznz rolznz rolznz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reneaaron @rolznz