This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
feat: add expiry notices to connection cards #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rolznz
commented
Jun 18, 2024
•
rolznz
commented
bumi
reviewed
Jun 18, 2024
rolznz
commented
Jun 19, 2024
| {connection.lastEventAt && ( | ||
| <div className="flex flex-row justify-between text-xs items-center"> | ||
| <div className="flex flex-row justify-between"> | ||
| <div>Last used: </div> |
There was a problem hiding this comment.
Last used was removed from the card, is this intentional?
There was a problem hiding this comment.
@reneaaron I think it's useful information to have
There was a problem hiding this comment.
@rolznz It definitely is, however the cards are already quite clogged with data. I wonder if it's really worth showing this info on the overview (we show it on the detail page anyway).
There was a problem hiding this comment.
I agree the card is a bit cluttered, maybe we can find a better solution. But having to manually click all the cards to open them to see which ones were used recently is not so great in my opinion
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.