This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
fix: build proper Docker image for arm64 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolznz
reviewed
Jun 25, 2024
.github/workflows/multiplatform.yaml
Outdated
| release: | ||
| types: [published] | ||
| jobs: | ||
| build: | ||
| env: | ||
| REGISTRY: ghcr.io | ||
| IMAGENAME: ${{ github.event.repository.name }} | ||
| TAG: ${{ github.ref_name }} |
There was a problem hiding this comment.
The IMAGENAME is the same as our existing docker file? should we remove the old workflow then since this seems to do both?
Initially I thought we'd only run this one on release as it's slower, but I'm not sure if it's worthwhile to do this and have to maintain two separate workflows
There was a problem hiding this comment.
It's probably a good idea to make sure all platforms compile as well. @rdmitr does this make sense to you? let's remove the other docker workflow?
There was a problem hiding this comment.
@rolznz Yeah, I didn't change this part. Found it a bit surprising but left it anyways. I guess the other Docker workflow is safe to delete
|
@rolznz The Linux-amd64 Docker build action is now removed 💨 |
This was referenced Jun 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes getAlby/hub#49