No more default protocol-redirect #107
Conversation
as more apps are implementing NWC now it does not properly work anymore to open the correct app there. the default app is no longer the used app
This allows apps that embed a webview for example to enable the connection to listen to this event an know when the connection was successfuly enabled.
|
actually I don't think it feels good. 
maybe just like this: do we need a back button? |
What does the back button do? the connection is already created. The normal browser button takes you back to the create connection screen but some of the form fields are not preserved (like the connection name). Also, the connection is already created at that point, so going back is going to leave an unused connection for the user. I don't think that's very good. |
|
|
views/apps/create.html
Outdated
| {{if not (eq .PairingSecret "")}} | ||
| <p class="mb-4 dark:text-white">Use the pairing secret to connect to your app.</p> | ||
| <a href="{{.PairingUri}}" class="w-full inline-flex bg-purple-700 cursor-pointer duration-150 focus:outline-none font-medium hover:bg-purple-900 items-center justify-center px-3 py-2 rounded-md shadow text-white transition mb-4"> | ||
| <svg class="mr-2" width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> |
There was a problem hiding this comment.
I don't think we should directly embed svgs like this, what was the reason for the change?
There was a problem hiding this comment.
We can't add a fill to svgs if we use them from the img tag
There was a problem hiding this comment.
@im-adithya what about a template, like {{template "copyIcon" .}} and then move the copy icon to a separate html file?
There was a problem hiding this comment.
Not very sure about that, it works, but then again we have to mention each and every icon used in that file in echo_handlers.go to parse it
I also felt at first but what Roland says makes sense, but it still expects us to click "Connections" from the navbar to go back which somehow doesn't feel right. And also if we place a back button we might also want to change the wording "Pair with app to finalize" because it doesn't look like the creation is done yet and might confuse into thinking they're aborting it (which is definitely not the case) (Another way to do is to delete the connection when back is pressed which is unnecessarily complicated) |
# By Roland Bewick (20) and others # Via GitHub (13) and others * main: (38 commits) chore: add dependabot feat: add support both internal and public relay URL fix: relay public url fix: expiresAt and maxAmount handling fix: app expiresAt handling fix: style for darkmode chore: correctly handle query parameters in new UI (WIP) chore: rename app name parameter (#154) fix: navbar padding on lg fix: ui cleanup no more default protocol-redirect (#107) ui improvements & layout simplification (#153) feat: nwc connection page ui (#151) chore: address migration feedback chore: format with prettier feat: run css scripts via npm chore: add human-readable name to migration ids feat: add manual migrations using gormigration fix: don't log resp id fix: convert expiresAt to int ... # Conflicts: # main.go
* feature/breez-backend: (38 commits) chore: add dependabot feat: add support both internal and public relay URL fix: relay public url fix: expiresAt and maxAmount handling fix: app expiresAt handling fix: style for darkmode chore: correctly handle query parameters in new UI (WIP) chore: rename app name parameter (#154) fix: navbar padding on lg fix: ui cleanup no more default protocol-redirect (#107) ui improvements & layout simplification (#153) feat: nwc connection page ui (#151) chore: address migration feedback chore: format with prettier feat: run css scripts via npm chore: add human-readable name to migration ids feat: add manual migrations using gormigration fix: don't log resp id fix: convert expiresAt to int ...
as more apps are implementing NWC now it does not properly work anymore to open the correct app there. the default app is no longer the requested app.
We add the option for a button to open the
nostr+walletconnectlink, allow users to copy the NWC string AND also fire events on window and the window.opener to allow apps to listen to those events (especially in when apps open the NWC confirmation URL or use an embedded webview.e.g. zapplepay
Missing: