Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): Add icon assets #252

Merged
merged 1 commit into from
Aug 16, 2023
Merged

feat(icon): Add icon assets #252

merged 1 commit into from
Aug 16, 2023

Conversation

diogomateus
Copy link
Collaborator

What this PR does

This PR adds the SVG assets and generated React components (by using yarn generate-icons).

Test this by visiting Icons List story or detail Icon story.

Screenshot

Screenshot 2023-08-15 at 11 08 23

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

Copy link
Contributor

@vincentaudoire vincentaudoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that this does not inflate the imported bundle size?

@diogomateus
Copy link
Collaborator Author

Have you checked that this does not inflate the imported bundle size?

I believe it's fine but since I've been working on this one on the side I'll do some extra checks with a pre-release and show a report here 🤞

@diogomateus diogomateus merged commit 1b32871 into main Aug 16, 2023
4 of 5 checks passed
@diogomateus diogomateus deleted the diogo/icon-assets branch August 16, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants