Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): [EMU-4092] update vertical padding #258

Merged

Conversation

a-maffei
Copy link
Contributor

@a-maffei a-maffei commented Sep 4, 2023

What this PR does

  1. Updates the bordered checkbox component's vertical padding (from 8px to 12px)
  2. This change is also reflected on the CSS radio button component since it also uses the p-label--bordered class.

Current:
EMU-4092-current

Updated:
EMU-4092-updated

Why is this needed?

Solves:
EMU-4092

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

Copy link
Collaborator

@diogomateus diogomateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@talo242 talo242 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅🏼

@a-maffei a-maffei merged commit 1b6c8f8 into main Sep 4, 2023
4 checks passed
@a-maffei a-maffei deleted the alessandra/emu-4092-update-padding-on-checkbox-component branch September 4, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants