Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): Fix icon wrapper not centering SVG #264

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Conversation

diogomateus
Copy link
Collaborator

@diogomateus diogomateus commented Sep 14, 2023

What this PR does

Icons paths were not centered withing SVG causing a slight disalignment:
Before:
Screenshot 2023-09-14 at 13 48 33

After:
Screenshot 2023-09-14 at 13 47 19

Solves:
STO-XXX
EMU-XXX
RVN-XXX

How to test?

Please include additional context on how to test this PR.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@diogomateus diogomateus merged commit 023adda into main Sep 15, 2023
@diogomateus diogomateus deleted the diogo/icon-centered branch September 15, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants