Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(images): Fix images types and add missing card exports #281

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

diogomateus
Copy link
Collaborator

@diogomateus diogomateus commented Oct 26, 2023

What this PR does

This PR removes as const from image assets as they are breaking private-signup. This still allows autocompletion from types and we can still use IllustrationKeys types.

This PR also adds missing cards exports.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@github-actions github-actions bot added the Fix label Oct 26, 2023
@diogomateus diogomateus marked this pull request as ready for review October 26, 2023 09:23
@diogomateus diogomateus changed the title fix(images): Fix images types fix(images): Fix images types and add missing card exports Oct 26, 2023
@diogomateus diogomateus merged commit a8d10c6 into main Oct 26, 2023
4 checks passed
@diogomateus diogomateus deleted the diogo/images-as-const branch October 26, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants