Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-dropzone): Fix MultiDropzone not uploading when clicking on label #282

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

diogomateus
Copy link
Collaborator

What this PR does

If clicking on the Choose file or drag & drop label on a safari browser, the upload isn't triggered.

Behaviour can be reproduced here.

This seems to be caused by the fact that we are triggering our own id while react-dropzone creates its own input reference inside.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@diogomateus diogomateus force-pushed the diogo/multi-dropzone-label-breaking-upload branch from 1f15be3 to 2cc4385 Compare November 17, 2023 15:02
@diogomateus diogomateus merged commit 7ba9671 into main Nov 17, 2023
4 checks passed
@diogomateus diogomateus deleted the diogo/multi-dropzone-label-breaking-upload branch November 17, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants