Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon): [EMU-7000] Fix icons shrinking #287

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Conversation

diogomateus
Copy link
Collaborator

What this PR does

This PR adds a min-width property to icon wrapper preventing icons from shrinking below their width on some layout definitions.

Why is this needed?

When setting icons on layouts (like flex), sometimes content shrinks under the minimum wanted width, one example being the multi drop zone component:

Before:
Screenshot 2023-12-13 at 09 39 50

After:
Screenshot 2023-12-13 at 09 39 53

Solves:
EMU-7000

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@diogomateus diogomateus merged commit e5627a7 into main Dec 13, 2023
4 checks passed
@diogomateus diogomateus deleted the diogo/icon-min-width branch December 13, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants