Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(modal): Add Create a modal component using the Popover API #320

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ruheni
Copy link
Contributor

@ruheni ruheni commented Jun 10, 2024

What this PR does

This pull request adds a new component called RegularModalPopoverApi. This component is used to create a regular modal using the Popover API. This component provides a flexible and customizable way to create modals with popover behavior.

Why is this needed?

Please include relevant motivation and context of why this PR is necessary, sentry/linear/notion/...

Solves:
STO-XXX
EMU-XXX
RVN-XXX

How to test?

Run yarn storybook and navigate to: http://localhost:9009/?path=/story/jsx-modals--regular-modal-popover-api-story

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant