feat(table): Add Card Cell and hideColumns property #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimkwanka
approved these changes
Jul 23, 2024
kimkwanka
reviewed
Jul 24, 2024
| type BaseCellData = BaseCellProps & { type?: undefined }; | ||
| type CTACellData = CTACellProps & { type: 'CTA' }; | ||
| type ButtonCellData = ButtonCellProps & { type: 'BUTTON' }; | ||
| type DefaultCellProps = { colSpan?: number }; |
There was a problem hiding this comment.
Why is this needed here though?
There was a problem hiding this comment.
Missed this comment before merging. Just for consistency, we might want to add a single text on all columns or even a single boolean value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the hideColumns property that allows hiding a column by prop setting.
This PR adds the Card Cell variant of cell rendering.
This PR adds minor fixes to styles breaking on website.
How to test?
Please include additional context on how to test this PR.
Checklist:
Or give a reason why this does not apply:
Or give a reason why this does not apply:
Browser support
My code works in the following browsers: