Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(table): [NoTicket] Fix and clean up types #369

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

kimkwanka
Copy link
Contributor

What this PR does

This PR cleans up and fixes some types.

Why is this needed?

Please include relevant motivation and context of why this PR is necessary, sentry/linear/notion/...

Solves:
STO-XXX
EMU-XXX
RVN-XXX

How to test?

Please include additional context on how to test this PR.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

Copy link
Collaborator

@diogomateus diogomateus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My freaky prettier config 🥲

@kimkwanka kimkwanka merged commit 2ea81dc into main Jul 24, 2024
4 checks passed
@kimkwanka kimkwanka deleted the kim/noticket-clean-up-type branch July 24, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants