Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(collapsible): [SIDE-431] Use custom Collapsible implementation #373

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

kimkwanka
Copy link
Contributor

What this PR does

This PR fixes the Collapsible component by replacing react-animate-height with a custom implementation.

This retains the sticky positioning of items while animating smoothly even on mobile.

Screen.Recording.2024-07-25.at.12.58.30.mov

Why is this needed?

Please include relevant motivation and context of why this PR is necessary, sentry/linear/notion/...

Solves:
SIDE-431

How to test?

Please include additional context on how to test this PR.

Checklist:

  • I reviewed my own code
  • The changes align with the designs I received
    Or give a reason why this does not apply:
  • I have attached screenshot(s), video(s) or gif(s) showing that the solution is working as expected
    Or give a reason why this does not apply:
  • I have updated the task(s) status on Linear
  • All new media is optimized (images, gifs, videos)

Browser support

My code works in the following browsers:

  • Firefox
  • Chrome
  • Safari
  • Edge

@kimkwanka kimkwanka requested a review from diogomateus July 25, 2024 11:41
@kimkwanka kimkwanka merged commit 26bbc84 into main Jul 25, 2024
4 checks passed
@kimkwanka kimkwanka deleted the kim/side-431-fix-collapsible-on-mobile branch July 25, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants