Skip to content
This repository has been archived by the owner on May 27, 2022. It is now read-only.

feat: support ~/ on Local project #312

Merged
merged 5 commits into from
Oct 11, 2019
Merged

feat: support ~/ on Local project #312

merged 5 commits into from
Oct 11, 2019

Conversation

jesseleite
Copy link
Contributor

See conversation regarding ~/ local path expansion in #311.

@jesseleite
Copy link
Contributor Author

jesseleite commented Oct 10, 2019

My test passes. Not sure if any tests should/can be written in project_test.go or bundle_test.go though? I'm not sure how to mock/swap usr.HomeDir with the test suite's tmp directory.

When building and testing manually, this all seems to work great though.

@codecov-io
Copy link

Codecov Report

Merging #312 into master will increase coverage by 0.39%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   78.22%   78.62%   +0.39%     
==========================================
  Files          12       12              
  Lines         271      276       +5     
==========================================
+ Hits          212      217       +5     
  Misses         54       54              
  Partials        5        5
Impacted Files Coverage Δ
project/project.go 100% <100%> (ø) ⬆️
project/local.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de4f878...9088747. Read the comment docs.

@caarlos0 caarlos0 changed the title Local ~/ path expansion feat: support ~/ on Local project Oct 11, 2019
@caarlos0
Copy link
Member

I'll merge and refactor some things on antibody to make this better, thanks!

@caarlos0 caarlos0 merged commit 4c489ff into getantibody:master Oct 11, 2019
@jesseleite jesseleite deleted the bundle-file-loading-from-home branch October 11, 2019 17:59
@jesseleite
Copy link
Contributor Author

Awesome, and thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants