Skip to content

Commit

Permalink
Merge pull request #515 from jasperges/fix505
Browse files Browse the repository at this point in the history
Remove unneeded `config` variable from host (un)install (closes #505)
  • Loading branch information
BigRoy authored Jan 24, 2020
2 parents add240f + 2a68a1f commit ace0c79
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 18 deletions.
8 changes: 2 additions & 6 deletions avalon/fusion/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def ls():
yield container


def install(config):
def install():
"""Install Fusion-specific functionality of avalon-core.
This function is called automatically on calling `api.install(fusion)`.
Expand All @@ -76,14 +76,10 @@ def install(config):
logger.setLevel(logging.DEBUG)


def uninstall(config):
def uninstall():
"""Uninstall Fusion-specific functionality of avalon-core.
This function is called automatically on calling `api.uninstall()`.
Args:
config: configuration module
"""

pyblish.api.deregister_host("fusion")
Expand Down
8 changes: 2 additions & 6 deletions avalon/houdini/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
IS_HEADLESS = not hasattr(hou, "ui")


def install(config):
def install():
"""Setup integration
Register plug-ins and integrate into the host
Expand All @@ -40,14 +40,10 @@ def install(config):
self._has_been_setup = True


def uninstall(config):
def uninstall():
"""Uninstall Houdini-specific functionality of avalon-core.
This function is called automatically on calling `api.uninstall()`.
Args:
config: configuration module
"""

pyblish.api.deregister_host("hython")
Expand Down
4 changes: 2 additions & 2 deletions avalon/maya/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
IS_HEADLESS = not hasattr(cmds, "about") or cmds.about(batch=True)


def install(config):
def install():
"""Install Maya-specific functionality of avalon-core.
This function is called automatically on calling `api.install(maya)`.
Expand Down Expand Up @@ -90,7 +90,7 @@ def get_main_window():
return self._parent


def uninstall(config):
def uninstall():
"""Uninstall Maya-specific functionality of avalon-core.
This function is called automatically on calling `api.uninstall()`.
Expand Down
4 changes: 2 additions & 2 deletions avalon/nuke/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def ls():
yield container


def install(config):
def install():
"""Install Nuke-specific functionality of avalon-core.
This is where you install menus and register families, data
Expand Down Expand Up @@ -241,7 +241,7 @@ def get_main_window():
return self._parent


def uninstall(config):
def uninstall():
"""Uninstall all that was previously installed
This is where you undo everything that was done in `install()`.
Expand Down
4 changes: 2 additions & 2 deletions avalon/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ def install(host):

# Optional host install function
if hasattr(host, "install"):
host.install(config)
host.install()

# Optional config.host.install()
host_name = host.__name__.rsplit(".", 1)[-1]
Expand Down Expand Up @@ -119,7 +119,7 @@ def uninstall():
config_host.uninstall()

try:
host.uninstall(config)
host.uninstall()
except AttributeError:
pass

Expand Down

0 comments on commit ace0c79

Please sign in to comment.