Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Avalon-Nuke implementation #471

Merged
merged 5 commits into from
Nov 5, 2019

Conversation

davidlatwe
Copy link
Collaborator

@davidlatwe davidlatwe commented Nov 5, 2019

Problem

Nuke launched from Avalon will instantly crashed due to some missing function and module-not-found error.

What's changed

  • Cleanup a bit so I can launch Nuke without any error.
    • Import toml from avalon.vendor (c78255b)
    • Remove ls_img_sequence (fb4cde5)
  • Instead of hard-coded to use pyblish-lite, revert back to use avalon.tools.publish so one can register any pyblish GUI on demand via using pyblish.register_gui in config module. (Also, did not encounter Doesn't work with Nuke pyblish/pyblish-qml#301, even so, no reason to hard code for fix 😌 ) (b668318)

The function `ls_img_sequence` has been removed in commit 74c969d
Instead of hard-coded to use pyblish-lite, use pyblish.register_gui.
@davidlatwe
Copy link
Collaborator Author

Before I actually step into #438, I need this PR to be merged.

Copy link
Collaborator

@tokejepsen tokejepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cant test, but the code good.

@davidlatwe
Copy link
Collaborator Author

For completeness, here's the error message I got while launching before this PR.

NukeX 9.0v7, 64 bit, built Aug 17 2015.
Copyright (c) 2015 The Foundry Visionmongers Ltd.  All Rights Reserved.
Traceback (most recent call last):
  File "C:\Users\david\Dropbox\github\AVALON\avalon-core/setup/nuke/nuke_path/menu.py", line 2, in <
module>
    import avalon.nuke
  File "C:\Users\david\Dropbox\github\AVALON\avalon-core\avalon\nuke\__init__.py", line 7, in <modul
e>
    from .lib import (
  File "C:\Users\david\Dropbox\github\AVALON\avalon-core\avalon\nuke\lib.py", line 6, in <module>
    import toml
ImportError: No module named toml

And Nuke went down.

Copy link
Collaborator

@BigRoy BigRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test on my end but the code changes look good to me.

@davidlatwe
Copy link
Collaborator Author

Merging this ! 🚀

@davidlatwe davidlatwe merged commit 54af4a6 into getavalon:master Nov 5, 2019
@davidlatwe davidlatwe deleted the nuke-workable branch November 5, 2019 10:31
@davidlatwe davidlatwe mentioned this pull request Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants