Close Workfiles window on Open

[tokejepsen]

Fix for #544

[tokejepsen]

Seems to be some issues with coveralls and MacOS builds.

This PR is ready to merged otherwise.

[mkolar]

I'm happy with this

[BigRoy]

I did intentionally remove the behavior when I implemented the new tool as I used it much more to quickly browse and go between different scenes where having it open appeared faster to me. Nevertheless, I'm fine with closing on open - especially because it seems the preference for most people. 👍

[davidlatwe]

Nice :D
Just a note. This only changes the behavior of on_open_pressed, not on_browse_pressed.(changed in 716bd78)
Maybe we could add a checkbox "Close on file open" in next PR, so it can be on demand.

[BigRoy]

Just a note. This only changes the behavior of on_open_pressed, not on_browse_pressed.

That's actually a very good point. Maybe this is better placed in the open_file method of the Widget.

[tokejepsen]

That's actually a very good point. Maybe this is better placed in the open_file method of the Widget.

Sure, we can do that!

[iLLiCiTiT]

• I would add "action" to workfiles view which will allow to open workfile and keep window opened if @BigRoy need that?

[BigRoy]

I would add "action" to workfiles view which will allow to open workfile and keep window opened if @BigRoy need that?

Not sure what you mean with Action? Do you mean a toggle somewhere, or a right mouse context menu?

Anyway, having the option to keep it open is no hard requirement for me. So I'd be happy to merge as is and potentially open an issue if it becomes a problem.

[iLLiCiTiT]

Not sure what you mean with Action? Do you mean a toggle somewhere, or a right mouse context menu?

Sorry for ugliness.

[BigRoy]

Ah yes, I wouldn't bother. It wouldn't be very clear that that specific one would then not close the Window, right?

For me this is ready to merge as is.

[BigRoy]

For what it's worth - just heard back from some Artists who also stated they "tend to keep it open" to quickly browse between different shots for some minor things. I'll create a separate issue to discuss a potential "toggle" to keep the tool open.

[davidlatwe]

If no other objections, merging this in one hour (reach 24 hr) !