Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a starter for Deno/Hono #41

Closed
chrisnurse opened this issue Nov 3, 2024 · 8 comments · Fixed by #42
Closed

Provide a starter for Deno/Hono #41

chrisnurse opened this issue Nov 3, 2024 · 8 comments · Fixed by #42
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed released 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@chrisnurse
Copy link

chrisnurse commented Nov 3, 2024

Following in the tracks of Hono, and their "cross-platform" approach, Pylon looks like an excellent project with a vision for making APIs simpler.

I would find it very useful to be able to launch a template project which uses deno, and also deno with Hono.

Some concepts which are gaining a lot of interest from the community are the speed at which we can build services, which can also automatically support RPC and GrapQL, whilst also leveraging the power of Zod for rapid validation of inputs and outputs.

Thanks!

@schettn schettn self-assigned this Nov 3, 2024
@schettn schettn added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ⭐ goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software labels Nov 3, 2024
@schettn
Copy link
Contributor

schettn commented Nov 3, 2024

Hi! Thanks for the issue.

I will do some research next week and then add Deno as a supported Pylon runtime.

@chrisnurse
Copy link
Author

chrisnurse commented Nov 4, 2024

Thanks for the quick reply!

If it's useful at all, and you're a fan of devcontainers, as I am...

https://github.com/DenoBlox/devcontainer

This repo drops a dev container configuration into your project folder. It might just help you get deno setup, if you havent already, and keep your stuff isolated.

@schettn
Copy link
Contributor

schettn commented Nov 4, 2024

I use Codespaces quite often, but I have never bothered to configure the devcontainer.

I would happily accept a PR that adds devcontainers to Pylon.

This configuration must support Nodejs, Bun and Deno.

Some pre installed extensions like GitHub, Copilot and prettier would also be nice.

In addition, I think that project with Pylon npm create pylon could also benefit from dev containers. There we would need separate the containers based on the runtime.

@schettn
Copy link
Contributor

schettn commented Nov 4, 2024

@chrisnurse

I am trying to use a tsconfig.json with Deno.

{
  "extends": "@getcronit/pylon/tsconfig.pylon.json",
  "include": ["pylon.d.ts", "src/**/*.ts", "pylon.test.ts"]
}

The problem is that the extends does not work because there are no node_modules in Deno.

image

Any idea what could be the issue?

@chrisnurse
Copy link
Author

I think that would have to be merged into deno.json

@schettn
Copy link
Contributor

schettn commented Nov 4, 2024

Apparently you can specify the tsconfig with --config tsconig.json and use "nodeModulesDir": "auto" inside the Deno.json to get the extends working.

schettn added a commit that referenced this issue Nov 4, 2024
- Added support for detecting Deno as a package manager
- Created a new file, detect-pm.ts, to handle package manager detection logic
- Updated index.ts to include Deno as a runtime option
- Added Deno-specific files and configurations to the default Deno template

closes #41
@schettn schettn closed this as completed in de29921 Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

🎉 This issue has been resolved in version create-pylon-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 7, 2024

🎉 This issue has been resolved in version @getcronit/pylon-v2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ⭐ goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed released 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants