Cleanup demo app dependencies. Add local testing instructions #107
Conversation
build.gradle
Outdated
| return prop.get(key) | ||
| } | ||
|
|
||
| ext.getProperty = { name, defValue -> |
There was a problem hiding this comment.
I know this was just moved around from a different gradle script, but I'm not convinced that having two similarly worded methods findProperty and getProperty are the right way to go.
I think using a more specific name like getValueFromLocalProperties might be better.
There was a problem hiding this comment.
I like that idea too, I'll update the PR.
gradle/deploy.gradle
Outdated
| @@ -37,7 +37,9 @@ afterEvaluate { | |||
| from components.release | |||
| artifactId libraryArtifactId | |||
| groupId = 'live.ditto' | |||
| version = findProperty("LIBRARY_VERSION") | |||
|
|
|||
| def versionPropertyName = "LIBRARY_VERSION" | |||
There was a problem hiding this comment.
I'm wondering if no LIBRARY_VERSION can be found I just set to "0.0.0" as a default?
There was a problem hiding this comment.
It means one less step in publishing locally.
There was a problem hiding this comment.
That's a good shout - maybe just use a different string to avoid potential confusion with real semver? SNAPSHOT or something like that.
If you do it also keep in mind the order of precedence for properties - https://docs.gradle.org/current/userguide/build_environment.html#priority_for_configurations
Currently the pipeline injects the prop as an environment variable which has the lowest precedence according to their docs - so if you stick the hardcoded test version in gradle.properties it will always take it from there.
There was a problem hiding this comment.
Would this be a good change such that it won't affect the GH action/publishing to maven, but for publishing locally it would just use "SNAPSHOT" as the version?
version = findProperty("LIBRARY_VERSION") ?: "SNAPSHOT"
There was a problem hiding this comment.
Cool, I'll update the PR and readme
Fixes https://github.com/getditto/DittoAndroidTools/issues/104
Cleaned up the dependencies.
Also added instructions if someone wanted to test tools changes either locally or in an external project.
Added the ability to set the local version number in
local.propertiesfile (since the file doesn't get committed, less chance of something changing that we don't want). When running./gradlew publishToMavenLocalit will use the version set there. This should NOT affect publishing to Maven or the Github action - those should work as expected.