Add Wifi Aware as a section in the health tool #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/orgs/getditto/projects/32/views/1?pane=issue&itemId=74940891&issue=getditto%7CDittoAndroidTools%7C112
Adds Wifi Aware checking capability to the Health tool. The tool returns one of 3 statuses:
SUPPORTED - Wifi Aware is available for the device
UNSUPPORTED - Wifi Aware is not available for the device
UNSUPPORTED_ANDROID_VERSION - Using a version of Android older than 8.0/sdk 26 which is when Wifi Aware support was added
I have also updated the device details display the Android version and SDK version more clearly.
As for changes to the Health tool in general I have updated the
HealthScreen()with an optional parameter to determine which tools are displayed (and the order is preserved). By default it displays all health items (Permissions and Wifi Aware capability).Finally I found an issue with the dependency constraints for the Ditto SDK and those are fixed in this PR.
Below are some screenshots of the different states on different form factors (phone vs. tablet):