Zan/unify packages remove modules #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and healthmetrics
…others crash because they arent implemented)
zmarkan
force-pushed
the
zan/unify-packages-remove-modules
branch
from
6761318 to
0c0d1d1
Compare
|
I think we can go ahead and delete the old folders that used to be modules |
rajramsaroop
requested changes
Jan 21, 2025
AndroidDittoTools/src/main/java/live/ditto/tools/health/data/HealthUiState.kt
Outdated
Show resolved
Hide resolved
|
Addressed all the above - ready to be reviewed again @rajramsaroop |
rajramsaroop
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: Merging all tools into a single module - need to do that first before attempting any tree shaking. So far so good.