Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default DiskUsage HealthMetric unhealthy limit to 500MB instead of 2GB #88

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

bplattenburg
Copy link
Member

Also includes a minor refactor to align the logic flow and bytes math to match how DittoSwiftTools does things (everything in bytes)

Closes #87

@bplattenburg bplattenburg requested a review from rajramsaroop June 7, 2024 19:23
@bplattenburg
Copy link
Member Author

@rajramsaroop I tried to refactor a bit to address your feedback and bring this closer to how the DittoSwiftTools version works

@rajramsaroop
Copy link
Contributor

@rajramsaroop I tried to refactor a bit to address your feedback and bring this closer to how the DittoSwiftTools version works

In general (personally) I think the same API's but for different platforms should match (in terms of naming, input/outputs etc), but anything that might be platform specific should look like what a developer of that platform expects. I think what we have here is OK for now (since we're favoring speed over perfection lol).

@bplattenburg
Copy link
Member Author

@rajramsaroop when you get a chance, can you rough out the refactor you think makes sense into its own issue for this repo? Its worth revisiting and making sure we've decoupled the UI and HealthMetricProvider portions of this tool fully.

@bplattenburg bplattenburg merged commit 43552e8 into main Jun 21, 2024
@bplattenburg bplattenburg deleted the bp/500mb-unhealthy_disk branch June 21, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Disk Usage HealthMetric unhealthy value
2 participants