-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default DiskUsage HealthMetric unhealthy limit to 500MB instead of 2GB #88
Conversation
…S logic for how byte math is done
DittoDiskUsage/src/main/java/com/example/dittodiskusage/DiskUsageViewModel.kt
Show resolved
Hide resolved
DittoDiskUsage/src/main/java/com/example/dittodiskusage/usecase/GetDiskUsageMetrics.kt
Show resolved
Hide resolved
@rajramsaroop I tried to refactor a bit to address your feedback and bring this closer to how the |
In general (personally) I think the same API's but for different platforms should match (in terms of naming, input/outputs etc), but anything that might be platform specific should look like what a developer of that platform expects. I think what we have here is OK for now (since we're favoring speed over perfection lol). |
@rajramsaroop when you get a chance, can you rough out the refactor you think makes sense into its own issue for this repo? Its worth revisiting and making sure we've decoupled the UI and HealthMetricProvider portions of this tool fully. |
Also includes a minor refactor to align the logic flow and bytes math to match how DittoSwiftTools does things (everything in bytes)
Closes #87