pkg-config files are broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute #517
Comments
|
Reopened because current implementation depends on cmake_path which is not available on Ubuntu 20.04 (see #528). We need to include the module referenced in “Concatenating paths when building pkg-config files”. |
This was referenced Jan 7, 2023
alexeys85
pushed a commit
to alexeys85/packages
that referenced
this issue
Jan 11, 2023
Changelog from upstream (https://github.com/getdnsapi/getdns/releases/tag/v1.7.3): * 2022-12-22: Version 1.7.3 * PR getdnsapi/getdns#532: Increase CMake required version 3.5 -> 3.20, because we need cmake_path for Absolute paths in pkg-config (See Issue getdnsapi/getdns#517) Thanks Gabriel Ganne * Updated to Stubby 0.4.3 quickfix release * 2022-08-19: Version 1.7.2 * Stubby updated to 0.4.2 quickfix release * 2022-08-19: Version 1.7.1 * Always send the `dot` ALPN when using DoT * Strengthen version determination for Libidn2 during cmake processing (thanks jpbion). * Fix for issue in UDP stream selection in case of timeouts. Thanks Shikha Sharma * Fix using asterisk in ipstr for any address. Thanks uzlonewolf. * Issue getdnsapi/stubby#295: rdata not correctly written for validation for certain RR type. Also, set default built type to RelWithDebInfo and expose CFLAGS via GETDNS_BUILD_CFLAGS define and via getdns_context_get_api_information() * Issue getdnsapi/getdns#524: Bug fixes from submodules' upstream? Thanks Johnnyslee * Issue getdnsapi/getdns#517: Allow Absolute path CMAKE_INSTALL_{INCLUDE,LIB}DIR in pkg-config files. Thanks Alex Shpilkin * Issue getdnsapi/getdns#512: Update README.md to show correct PGP key location. Thanks Katze Prior. Signed-off-by: Aquila Cooper <aquila@cpr.is>
1582130940
pushed a commit
to 1582130940/OpenWrt-Lean-Packages
that referenced
this issue
Jan 12, 2023
Changelog from upstream (https://github.com/getdnsapi/getdns/releases/tag/v1.7.3): * 2022-12-22: Version 1.7.3 * PR getdnsapi/getdns#532: Increase CMake required version 3.5 -> 3.20, because we need cmake_path for Absolute paths in pkg-config (See Issue getdnsapi/getdns#517) Thanks Gabriel Ganne * Updated to Stubby 0.4.3 quickfix release * 2022-08-19: Version 1.7.2 * Stubby updated to 0.4.2 quickfix release * 2022-08-19: Version 1.7.1 * Always send the `dot` ALPN when using DoT * Strengthen version determination for Libidn2 during cmake processing (thanks jpbion). * Fix for issue in UDP stream selection in case of timeouts. Thanks Shikha Sharma * Fix using asterisk in ipstr for any address. Thanks uzlonewolf. * Issue getdnsapi/stubby#295: rdata not correctly written for validation for certain RR type. Also, set default built type to RelWithDebInfo and expose CFLAGS via GETDNS_BUILD_CFLAGS define and via getdns_context_get_api_information() * Issue getdnsapi/getdns#524: Bug fixes from submodules' upstream? Thanks Johnnyslee * Issue getdnsapi/getdns#517: Allow Absolute path CMAKE_INSTALL_{INCLUDE,LIB}DIR in pkg-config files. Thanks Alex Shpilkin * Issue getdnsapi/getdns#512: Update README.md to show correct PGP key location. Thanks Katze Prior. Signed-off-by: Aquila Cooper <aquila@cpr.is>
SibrenVasse
pushed a commit
to SibrenVasse/packages
that referenced
this issue
Feb 26, 2023
Changelog from upstream (https://github.com/getdnsapi/getdns/releases/tag/v1.7.3): * 2022-12-22: Version 1.7.3 * PR getdnsapi/getdns#532: Increase CMake required version 3.5 -> 3.20, because we need cmake_path for Absolute paths in pkg-config (See Issue getdnsapi/getdns#517) Thanks Gabriel Ganne * Updated to Stubby 0.4.3 quickfix release * 2022-08-19: Version 1.7.2 * Stubby updated to 0.4.2 quickfix release * 2022-08-19: Version 1.7.1 * Always send the `dot` ALPN when using DoT * Strengthen version determination for Libidn2 during cmake processing (thanks jpbion). * Fix for issue in UDP stream selection in case of timeouts. Thanks Shikha Sharma * Fix using asterisk in ipstr for any address. Thanks uzlonewolf. * Issue getdnsapi/stubby#295: rdata not correctly written for validation for certain RR type. Also, set default built type to RelWithDebInfo and expose CFLAGS via GETDNS_BUILD_CFLAGS define and via getdns_context_get_api_information() * Issue getdnsapi/getdns#524: Bug fixes from submodules' upstream? Thanks Johnnyslee * Issue getdnsapi/getdns#517: Allow Absolute path CMAKE_INSTALL_{INCLUDE,LIB}DIR in pkg-config files. Thanks Alex Shpilkin * Issue getdnsapi/getdns#512: Update README.md to show correct PGP key location. Thanks Katze Prior. Signed-off-by: Aquila Cooper <aquila@cpr.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As per title:
getdns.pc.inandgetdns_ext_event.pc.inhaveand so can’t handle absolute paths in
CMAKE_INSTALL_{INCLUDE,LIB}DIR. This leads to broken .pc files on NixOS in particular.See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.
The text was updated successfully, but these errors were encountered: