Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance cerate reverse withdraw from admin dashboard #1910

Merged

Conversation

Aunshon
Copy link
Collaborator

@Aunshon Aunshon commented Jun 7, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

Admin can add new reverse withdrawal entry form admin dashboard reverse withdrawal menu.
image

How to test the changes in this Pull Request:

  1. Go to admin dashboard reverse withdrawal menu, there is a new button in the top Add new clicking on that admin can any reverse withdrawal entry

Changelog entry

Admin can add new reverse withdrawal entry form admin dashboard reverse withdrawal menu.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@Aunshon Aunshon added the In Progress The issues is being worked on label Jun 7, 2023
@Aunshon Aunshon self-assigned this Jun 7, 2023
@Aunshon Aunshon changed the title Enhance/cerate reverse withdraw by admin Enhance cerate reverse withdraw from admin dashboard Jun 7, 2023
@Aunshon Aunshon added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval and removed In Progress The issues is being worked on labels Jun 7, 2023
includes/REST/OrderController.php Outdated Show resolved Hide resolved
includes/REST/OrderController.php Outdated Show resolved Hide resolved
includes/REST/ReverseWithdrawalController.php Outdated Show resolved Hide resolved
includes/REST/ReverseWithdrawalController.php Outdated Show resolved Hide resolved
src/admin/pages/ReverseWithdrawal.vue Show resolved Hide resolved
src/admin/components/AddReverseWithdraw.vue Outdated Show resolved Hide resolved
src/admin/components/AddReverseWithdraw.vue Outdated Show resolved Hide resolved
src/admin/components/AddReverseWithdraw.vue Outdated Show resolved Hide resolved
src/admin/components/AddReverseWithdraw.vue Outdated Show resolved Hide resolved
src/admin/components/AddReverseWithdraw.vue Show resolved Hide resolved
@nurul-umbhiya nurul-umbhiya added Needs: Author Reply and removed Needs: Dev Review It requires a developer review and approval labels Jun 8, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Jun 19, 2023
@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01
Copy link
Contributor

Scenario:
kindly add tooltip for debit & credit Withdrawal Balance Type.

Screenshot:
Screenshot at Jul 04 13-33-06

@shashwatahalder01

This comment was marked as resolved.

@Aunshon Aunshon added Needs: Testing This requires further testing and removed Type: Bug labels Jul 12, 2023
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team QA In Progress and removed Needs: Testing This requires further testing QA In Progress labels Jul 13, 2023
@nurul-umbhiya nurul-umbhiya merged commit 33ea03f into getdokan:develop Jul 24, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vendor withdrawl issue
3 participants