Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: admin can change product author from rest api #1913

Conversation

shohag121
Copy link
Member

@shohag121 shohag121 commented Jun 9, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

  1. Check issue [Dokan API]: The admin is facing restrictions while creating and updating or trying to assign a product to a vendor. #1730

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

update: admin can change product author from REST API

Previously, product_author was read-only property, now admin can change product_author for an existing product or create a new product for another author.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@devAsadNur devAsadNur added the Needs: Dev Review It requires a developer review and approval label Jun 9, 2023
@shohag121 shohag121 added the Needs: Testing This requires further testing label Jun 9, 2023
@devAsadNur devAsadNur added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Jun 9, 2023
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team QA In Progress and removed Needs: Testing This requires further testing QA approved This PR is approved by the QA team labels Jun 9, 2023
@shashwatahalder01
Copy link
Contributor

@shohag121, Kindly merge develop

@shashwatahalder01

This comment was marked as resolved.

@shohag121 shohag121 added Needs: Testing This requires further testing and removed Type: Bug labels Jun 22, 2023
@shohag121

This comment was marked as resolved.

@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Jul 4, 2023
@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01

This comment was marked as resolved.

@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team Needs: Testing This requires further testing and removed QA In Progress QA approved This PR is approved by the QA team labels Jul 10, 2023
@shohag121
Copy link
Member Author

shohag121 commented Nov 2, 2023

@nurul-umbhiya needs a discussion on resolving merge conflicts.

@nurul-umbhiya
Copy link
Contributor

@shohag121 merge conflict has been fixed

@shashwatahalder01 shashwatahalder01 added QA In Progress QA approved This PR is approved by the QA team and removed Needs: Testing This requires further testing QA In Progress labels Apr 3, 2024
@shohag121 shohag121 merged commit 87b95cc into getdokan:develop Apr 4, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants