Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if method is async and await results, #199 #201

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

sriv
Copy link
Member

@sriv sriv commented Jan 29, 2024

Fixes #199

Signed-off-by: sriv srikanth.ddit@gmail.com

@sriv sriv added the ReleaseCandidate Pr that is eligible for a release label Jan 29, 2024
@gaugebot
Copy link

gaugebot bot commented Jan 29, 2024

@sriv Thank you for contributing to gauge-dotnet. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

@mpekurny mpekurny mentioned this pull request Jan 31, 2024
@sriv sriv force-pushed the 199_async_method_support branch from 483d555 to 7259238 Compare February 6, 2024 07:34
sriv and others added 6 commits February 6, 2024 13:05
Signed-off-by: sriv <srikanth.ddit@gmail.com>
* Add .NET 8 support

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Update the init command to create a newer csproj file and removed the matrix for different dotnet versions in the build.yml

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

* Limiting the number of nodes to use for the feature tests

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>

---------

Signed-off-by: Martin Pekurny <mpekurny@paychex.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
step implementations with async void are treated as not implemented

Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
Signed-off-by: sriv <srikanth.ddit@gmail.com>
the entire method execution chain is now async

Signed-off-by: sriv <srikanth.ddit@gmail.com>
@sriv sriv force-pushed the 199_async_method_support branch from 7259238 to ff37a99 Compare February 6, 2024 07:36
Signed-off-by: sriv <srikanth.ddit@gmail.com>
@sriv sriv merged commit b7550c9 into master Feb 6, 2024
7 checks passed
sriv added a commit that referenced this pull request Feb 13, 2024
@chadlwilson chadlwilson deleted the 199_async_method_support branch August 17, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseCandidate Pr that is eligible for a release
Development

Successfully merging this pull request may close these issues.

Gauge freezes when running async methods
2 participants