Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept start end notify runner #206

Merged

Conversation

PiotrNestor
Copy link
Contributor

@PiotrNestor PiotrNestor commented Feb 16, 2024

@sriv
Handle concept messages
Concept hooks support

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@sriv sriv added the ReleaseCandidate Pr that is eligible for a release label Feb 19, 2024
@gaugebot
Copy link

gaugebot bot commented Feb 19, 2024

@PiotrNestor Thank you for contributing to gauge-dotnet. Your pull request has been labeled as a release candidate 🎉🎉.

Merging this PR will trigger a release.

Please bump up the version as part of this PR.

Instructions to bump the version can found at CONTRIBUTING.md

If the CONTRIBUTING.md file does not exist or does not include instructions about bumping up the version, please looks previous commits in git history to see what changes need to be done.

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@PiotrNestor
Copy link
Contributor Author

@sriv
Corrected the failing ShouldMapStepDetails test

@sriv sriv enabled auto-merge (squash) February 19, 2024 09:46
@PiotrNestor
Copy link
Contributor Author

@sriv
There are issues with the 'Gauge.Dotnet.IntegrationTests'. Not clear to me ...

@sriv
Copy link
Member

sriv commented Feb 19, 2024

Yes, I could see the problem. I will look into it, but will need some time since I am away presently. My guess is that the cause could be because the seed projects in _testdata use older Gauge.CSharp.Lib and these seed projects are used in the integration tests.

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
auto-merge was automatically disabled February 19, 2024 13:32

Head branch was pushed to by a user without write access

Signed-off-by: Piotr Nestorow <piotr.nestorow@systemverification.com>
@PiotrNestor
Copy link
Contributor Author

PiotrNestor commented Feb 20, 2024

@sriv
In the _testdata sample projects:

  • added Concept hooks
  • updated gauge_bin/Gauge.CSharp.Lib.dll

Now the integration tests work for me
Passed! - Failed: 0, Passed: 28, Skipped: 0, Total: 28,

What is the update and build procedure for _testdata projects?

For example in _testdata/Sample:
gauge run specs

results in a lot of errors ...

@sriv sriv enabled auto-merge (squash) February 20, 2024 10:08
@sriv
Copy link
Member

sriv commented Feb 20, 2024

the _testdata projects are not full gauge projects, they just have enough for the integration tests. The gauge run command will throw errors, but we can ignore that since we are interested in getting the project built more than invoking gauge. Looks like the builds are passing now, fingers crossed...

@sriv sriv merged commit 5a9f766 into getgauge:master Feb 20, 2024
7 checks passed
@PiotrNestor PiotrNestor deleted the concept-start-end-notify-runner branch February 20, 2024 13:19
@sriv
Copy link
Member

sriv commented Feb 20, 2024

Finally, managed to get the tests and the template updated and the build went green.

Thank you for your patience @PiotrNestor and the contribution. I believe all the changes for this feature are now merged. Please tag me if you need me to look at anything. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ReleaseCandidate Pr that is eligible for a release
Development

Successfully merging this pull request may close these issues.

2 participants